Expose registration of physics servers to GDExtension #65427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rburing
force-pushed
the
register_custom_physics_server
branch
from
a1707e4 to
ccd6eb6
Compare
|
There is currently a segmentation fault on shutdown (when using a physics server from a GDExtension) because GDExtensions are deinitialized before physics is finalized, found by @derammo. Will think about the proper fix and push it soon. |
This exposes PhysicsServer2DManager and PhysicsServer3DManager.
rburing
force-pushed
the
register_custom_physics_server
branch
from
ccd6eb6 to
532e378
Compare
reduz
approved these changes
Sep 7, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes
PhysicsServer2DManagerandPhysicsServer3DManagerwith a minimalist API that can be used by GDExtensions:Note that the
Callablecan be conveniently created in engine/module code by usingcallable_mp_static(as can be seen in this PR). This convenience unfortunately does not seem to extend to GDExtension (so far). On the GDExtension side aCallablemust currently apparently be created from a bound method.Small test project: PhysicsServer2DExtension_test.zip