Determine ProjectSettings
' resource path early
#64925
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following sequence:
executable_path.pck
.FileAccess
doesfix_path()
, which forACCESS_FILESYSTEM
callsProjectSettings::get_singleton()->get_resource_path()
.FileAccess::open()
.This PR fixes that pathological case by just letting
ProjectSettings
fill the resource path value earlier.Separate PR submitted for 3.x: #64926.