-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix has_filter of AnimationNode not being called in scripts #64560
Conversation
Is this issue also present in 4.0.alpha? If so, please open a pull request against |
9fdfb76
to
efb0c39
Compare
I did a bit of testing and the issue is not on the 4.0.alpha |
As pointed by @Hiiamwilliam, the binding is wrong too: (falsely returns If it's quicker to also add it to this PR for getting it the 3.5 branch, please do so. |
efb0c39
to
abf93a5
Compare
I didn't catch that, I fixed it here too just in case. That reminds me that the doc also says that the methds should return a string. I'll open a PR to correct that too. |
Pull requests for the stable branch should be merged on Make sure the binding is updated as @michael-nischt described, then we can merge this in |
abf93a5
to
c988deb
Compare
The binding is corrected and I made sure the checks passed on my fork |
Seems to be indeed fixed in |
Cherry-picked for 3.5.1. |
In godot 3.5, The
has_filter()
method was not called when implemented in a custom AnimationNode, making it impossible to have the "Edit Filter" button show up in the editor.