[3.x] Fix multiple ubershader bugs #64096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly reverts the approach in godotengine#62628, which now the problem is better scoped, looks overengineered and instead focuses on the few cases where there's something to take care of.
RandomShaper
added
bug
topic:rendering
cherrypick:3.5
RandomShaper
force-pushed
the
fix_uberflicker_3.x
branch
from
909f457 to
edb1408
Compare
clayjohn
approved these changes
Aug 8, 2022
|
Thanks! |
This was referenced Aug 8, 2022
Closed
|
Cherry-picked for 3.5.1. |
akien-mga
removed
the
cherrypick:3.5
|
Does this also fix #64038 (the exposure flickering issue I mentioned)? |
|
Good question. I didn't test, but it may... Sadly, I have no time for testing it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've kept the fixes in separate commits, since each one addresses one specific issue, and I believe this way is better to convey information to future maintainers.
This mostly reverts the approach in [3.5] Avoid GL undefined behavior in ubershaders #62628, which now the problem is better scoped, looks overengineered and instead focuses on the few cases where there's something to take care of.
Fixes #63346.
Fixes #64040.