Fix axis snapping of CollisionPolygon2D's newly created vertex #64050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
cherrypick:3.x
akien-mga
approved these changes
Aug 8, 2022
|
Thanks! |
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.5.1. |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64012
In CollisionPolygon2D when you add a new vertex via clicking on an existing edge, that vertex can immediately be moved without releasing the left mouse button.
A copy collection of polygon vertexes that is used to determine their positions prior to being moved was populated before the new vertex was added which caused a critical error when later trying to reference that vertex when moving. This reference access only occured when snapping to axis via holding Shift key.
This fixes this behaviour by populating the collection after adding the new vertex.