Fix incorrect expression base in AnimationNodeStateMachinePlayback::_check_advance_condition
#63238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleonc
approved these changes
Jul 20, 2022
This comment was marked as outdated.
This comment was marked as outdated.
joaopedrosgs
changed the title
AnimationNodeStateMachinePlayback::_check_advance_condition
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Does / Can this resolve the second comment? #62530 (comment) |
Nope, this only solves the issue for the tree base. If you have any suggestions, I can try to fix it here. |
…_check_advance_condition`
|
Upon further inspection, setting the root node from the transition never worked, even on the original PR for this feature (#54327). I'm searching for a solution but haven't found anything yet. |
|
Just a note, for me, this can be merged already. Removing or fixing the node root from the transitions should be done on another PR. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably a typo when deciding the root to execute the advance expression.
Fixes #62530