Viewport stretch transform was calculated incorrectly #60706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verride upon size change. Transform scale was calculated using integer divison (Vector2i)
awsker
changed the title
|
@awsker Does this bug also occur in |
No, I discovered this bug when porting my project to alpha4 |
|
Superseded by #67331. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewport stretch transform was calculated using old size and/or view size 2d override upon size change. Transform scale was calculated using integer divison (Vector2i). There's a case to be made that the method stretch_transform() belongs in the Viewport class since it's already aware of the concept of stretching even though it's only used by the SubViewport. If this was the case, stretch_transform() could be automatically called inside _set_size on the Viewport, instead of relying on the caller to supply a new stretch_transform