Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix undo history for function name autocompletion #60231

Merged
merged 1 commit into from
Apr 14, 2022
Merged

[3.x] Fix undo history for function name autocompletion #60231

merged 1 commit into from
Apr 14, 2022

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Apr 14, 2022 •
edited
Loading

Fixes #59805.

  • Complete get_node at get_no|("path"). It became get_no"path") after undo.
  • Complete raise at rai|(). It became rai after undo.

The removal of additional parenthesis were not added to undo history.

It's OK on master.

@timothyqiu timothyqiu added this to the 3.5 milestone Apr 14, 2022
@timothyqiu timothyqiu requested a review from a team as a code owner April 14, 2022 06:42
@akien-mga akien-mga merged commit 79bcfb8 into godotengine:3.x Apr 14, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Apr 14, 2022
Closed
@timothyqiu timothyqiu deleted the undo-autocomplete branch April 14, 2022 08:22
@akien-mga
Copy link
Member

Cherry-picked for 3.4.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor usability
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@timothyqiu @akien-mga