Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong visible line count for newline #59765

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Fix wrong visible line count for newline #59765

merged 1 commit into from
Dec 12, 2022

Conversation

pfertyk
Copy link
Contributor

@pfertyk pfertyk commented Mar 31, 2022

Fixes #59359.

@pfertyk pfertyk requested a review from a team as a code owner March 31, 2022 20:31
@KoBeWi KoBeWi added this to the 3.5 milestone Mar 31, 2022
@akien-mga akien-mga requested a review from bruvzg July 2, 2022 22:12
@akien-mga akien-mga modified the milestones: 3.5, 3.x Jul 2, 2022
@akien-mga akien-mga added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jul 2, 2022
@akien-mga akien-mga requested a review from Paulb23 December 12, 2022 11:42
@akien-mga akien-mga modified the milestones: 3.x, 3.6 Dec 12, 2022
akien-mga
akien-mga approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively approving for a YOLO merge, but I'd be more confident with a check from @bruvzg or @Paulb23 (note: 3.x).

bruvzg
bruvzg approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine (and the change should not affect anything except visible line count, so should be safe).

@akien-mga akien-mga merged commit bfce0c1 into godotengine:3.x Dec 12, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Dec 12, 2022
Closed
@akien-mga
Copy link
Member

Cherry-picked for 3.5.2.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@bruvzg bruvzg bruvzg approved these changes

@Paulb23 Paulb23 Awaiting requested review from Paulb23

Assignees
No one assigned
Labels
bug topic:gui
Projects
3.x release management
Status: Done
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
4 participants
@pfertyk @akien-mga @bruvzg @KoBeWi