Fixes GDScript define nested dictionary and array as constants #59613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50285, note the regression was introduced in (#41983) (commit 3886a2f)
This issue seems to have been caused by the logic for checking const of elements being moved from
reduce_array
toconst_fold_array
(andreduce_dict
toconst_fold_dict
) by the regression. Thusreduce_expression
was not properly assigning const to these types.This PR just adds extra checks in
const_fold_array
andconst_fold_dict
to handle nested arrays/dicts.