Double click on scene tree element to focus currently selected node

[djrm]

In 3D it will focus in the first viewport
Enable double click for trees
closes #5788

[vnen]

Also closes #5791.

[akien-mga]

Looking at the rest of the API, I think those names would be better: set_delayed_text_editor(bool enabled) and is_delayed_text_editor_enabled() (or directly is_delayed_text_editor if it's clear enough).
See e.g. http://docs.godotengine.org/en/latest/classes/class_httpclient.html?highlight=enabled#class-httpclient-is-blocking-mode-enabled or http://docs.godotengine.org/en/latest/classes/class_graphedit.html?highlight=enabled#class-graphedit-is-right-disconnects-enabled

[djrm]

well those are shorter and basically used only in the engine so will change to the proposed ones

[reduz]

i think there is another option in tree, where you can choose if you want
doubleclick to edit, maybe we should make an enum with options like

EDITOR_ON_CLICK
EDITOR_ON_CLICK_SELECTED
EDITOR_ON_CLICK_SELECTED_DELAYED

On Fri, Jul 29, 2016 at 4:35 PM, Daniel Ramirez [email protected]
wrote:

In scene/gui/tree.h
#5956 (comment):

@@ -527,6 +530,9 @@ friend class TreeItem;

void set_value_evaluator(ValueEvaluator *p_evaluator);

• void set_delayed_text_editor_enabled(bool enabled);
• bool get_delayed_text_editor_enabled() const;

well those are shorter and basically used only in the engine so will
change to the proposed ones

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/5956/files/cf568acd52f15e2a90f3b7ec89013499cd73f3f1#r72848784,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z26Z-_IdFM3amyXfIDYZvb2gKEF_cks5qalYZgaJpZM4JXx3i
.

[djrm]

something like
Tree::set_trigger_edit_mode()

[akien-mga]

@djrm Do you still want to change those, or should we merge as is?

[djrm]

@akien-mga mm yeah i changed the functions according to your suggestions but i didn't understand what reduz said, so i will push my changes

[akien-mga]

Code looks good, I'll let @djrm reply to my above suggestion but otherwise it can be merged IMO.