Improve Visual Script editor to suggest the proper visual script nodes. #56252

Gallilus · 2021-12-26T15:31:06Z

proposal #3528

While filters are preset they are fully editable while searching.
The base is set relative to what input the editor gives.

It is way easier to use constants.
Its is possible to find content, not inside the base.

Property_selector.mp4

Fixes: godotengine/godot-proposals#3528

Gallilus · 2022-01-01T14:41:44Z

added a few tweaks and easier access to deconstructors.

fire

Approved on the design.

Need to build and check for crashes and mistakes on a technical review.

fire

Do the icons have tooltips?

Gallilus · 2022-01-01T18:52:16Z

Yes, even the searchbar

fire

Looks good to me.

akien-mga · 2022-01-04T21:27:57Z

Neither the current PR title nor the commit message ("Update visual script autocomplete") seem to be an accurate description of what this PR does, could you amend them?

See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind

fire · 2022-01-04T21:32:07Z

@Gallilus What do you think about this phrasing?

Improve Visual Script editor to suggest the proper visual script nodes.

Gallilus · 2022-01-04T21:37:20Z

Will amend tomorow.

fire · 2022-01-04T21:40:33Z

2022-01-04.13-38-56.mp4

Material for a future or this pull request.

The ability to search for inputs and [sequence] inputs. Outputs already give the correct search.

Gallilus · 2022-01-05T18:24:24Z

@akien-mga Happy new year.
And thanks for always having patience with my descriptions and writing.

fire · 2022-01-07T07:32:54Z

modules/visual_script/editor/visual_script_property_selector.h

-	VBoxContainer *vbc;
-
-	Vector<Variant::Type> type_filter;
+	VBoxContainer *vbox;


Fix later. set to nullptr

Sorry if this was confusing. I mean that the variables should be intitialized to like nullptr or 0, but since there's like 15 variables to check it can be left to another commit.

fire

I concentrated testing on functionality so thanks for catching the commit message and also missed class variable inititializing.

fire · 2022-01-09T23:17:43Z

@Chaosus Can you take a look?

Chaosus · 2022-01-10T07:52:41Z

modules/visual_script/editor/visual_script_property_selector.cpp

-		item->set_selectable(2, false);
-		item->set_metadata(2, connecting);
+void VisualScriptPropertySelector::select_from_visual_script(const Ref<Script> &p_script, bool clear_text) {
+	set_title(TTR("Select from visual script"));


Maybe the "Create Visual Script Node" title sounds better (just to be consistent with "Create Shader Node" in visual shaders).

"Create Visual Script Node" is not accurate, it allows you to select a node compatible with the visual script you are editing.
In my mind, Visual script nodes are things like sequences or conditions similar to keywords in GDScript.

Chaosus · 2022-01-10T07:59:54Z

Not sure whether it is related to this issue but there is a bunch of errors emitted when the node is created from base type(e.g Vector):

Chaosus · 2022-01-10T08:04:18Z

When there is no text entered in the search text edit it shows only a few keywords:

Does this intended? It looks incorrect for me - I expected to watch a full tree or at least all base class Properties + all keywords + all built-in methods.

Chaosus · 2022-01-10T08:06:21Z

Clicking on category closes a dialog and emits errors:

Add a check to prevent this from happening.

akien-mga · 2022-01-10T09:00:01Z

WIP for proposal #3528

Is it still WIP or ready? It would be good to amend the OP description if it's now fully implemented.

Gallilus · 2022-01-11T19:34:38Z

Next week I will try to fix the errors

Gallilus · 2022-01-17T19:35:11Z

Added the null pointers (28)

Fixed the error when dropping nodes.

When there is no text entered there are only a few keywords (visual script nodes) available. Yes else you are provided with too many options and there are no more options for flow control. To see all options press spacebar.

About the error when selecting greyed out options. Yes, it needs to be handled in further PR's. For the above example, it might be interesting to change the scope reference. What do you think people will want when they select a class?

I hope this is a mergeable starting point for further improvements.

Chaosus · 2022-01-21T09:20:16Z

When there is no text entered there are only a few keywords (visual script nodes) available. Yes else you are provided with too many options and there are no more options for flow control. To see all options press spacebar.

Alright, I'm not a specialist in visual scripts, so it might be ok. I just make a point that pressing the spacebar to show all members is a little bit counter-intuitive - in visual shaders, you see the full tree in the collapsed form at the beginning.

About the error when selecting greyed out options. Yes, it needs to be handled in further PR's. For the above example, it might be interesting to change the scope reference. What do you think people will want when they select a class?

I don't know, maybe you should add a check to ClassDB::is_class_exposed to prevent this and allow instantiate a class, or add a special name setlist to check before pressing.

Nevertheless, I think it's in a good state to merge.

akien-mga · 2022-01-21T09:35:23Z

Thanks!

Gallilus requested a review from a team as a code owner December 26, 2021 15:31

Gallilus marked this pull request as draft December 26, 2021 15:31

Calinou added enhancement topic:editor topic:visualscript labels Dec 26, 2021

Calinou added this to the 4.0 milestone Dec 26, 2021

Calinou mentioned this pull request Dec 26, 2021

Update visual script property selector #54875

Closed

9 tasks

Gallilus force-pushed the Update-visual-script-property-selector branch 3 times, most recently from 49b6d51 to 6144566 Compare December 28, 2021 17:24

Gallilus mentioned this pull request Dec 28, 2021

Improve the visual script property selector godotengine/godot-proposals#3528

Closed

Gallilus marked this pull request as ready for review December 28, 2021 18:14

Gallilus force-pushed the Update-visual-script-property-selector branch from 6144566 to efa1bef Compare January 1, 2022 14:20

fire approved these changes Jan 1, 2022

View reviewed changes

fire reviewed Jan 1, 2022

View reviewed changes

fire mentioned this pull request Jan 3, 2022

Search-list to make finding ANY engine function / method easy in visual script . . godotengine/godot-proposals#2555

Closed

fire approved these changes Jan 4, 2022

View reviewed changes

fire mentioned this pull request Jan 4, 2022

Fix property selector not displaying certain properties/methods #48751

Closed

Gallilus force-pushed the Update-visual-script-property-selector branch from efa1bef to 7be0e61 Compare January 5, 2022 18:20

fire mentioned this pull request Jan 6, 2022

Add an ability to search for a function and a variable in Visual Script by double-clicking at their name in the members window godotengine/godot-visual-script#25

Open

fire reviewed Jan 7, 2022

View reviewed changes

fire approved these changes Jan 7, 2022

View reviewed changes

fire mentioned this pull request Jan 9, 2022

Add context menu to visual script editor #56646

Merged

Chaosus reviewed Jan 10, 2022

View reviewed changes

akien-mga changed the title ~~Update visual_script_property_selector.cpp~~ Improve Visual Script editor to suggest the proper visual script nodes. Jan 10, 2022

Gallilus marked this pull request as draft January 11, 2022 19:30

Improve Visual Script editor to suggest the proper visual script nodes.

3a82f66

Gallilus force-pushed the Update-visual-script-property-selector branch from 7be0e61 to 3a82f66 Compare January 17, 2022 19:23

Gallilus marked this pull request as ready for review January 17, 2022 19:26

Gallilus requested review from Chaosus and fire January 17, 2022 19:26

akien-mga merged commit 20dfa0c into godotengine:master Jan 21, 2022

archerallstars mentioned this pull request Feb 17, 2022

Godot 4: transform node (3D) is missing from the Visual Script's property selector #58228

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve Visual Script editor to suggest the proper visual script nodes. #56252

Improve Visual Script editor to suggest the proper visual script nodes. #56252

Gallilus commented Dec 26, 2021 •

edited

Loading

Gallilus commented Jan 1, 2022

fire left a comment

fire left a comment

Gallilus commented Jan 1, 2022

fire left a comment

akien-mga commented Jan 4, 2022

fire commented Jan 4, 2022 •

edited

Loading

Gallilus commented Jan 4, 2022

fire commented Jan 4, 2022 •

edited

Loading

Gallilus commented Jan 5, 2022

fire Jan 7, 2022

fire Jan 9, 2022

fire left a comment •

edited

Loading

fire commented Jan 9, 2022

Chaosus Jan 10, 2022

Gallilus Jan 11, 2022

Chaosus commented Jan 10, 2022

Chaosus commented Jan 10, 2022 •

edited

Loading

Chaosus commented Jan 10, 2022 •

edited

Loading

akien-mga commented Jan 10, 2022

Gallilus commented Jan 11, 2022

Gallilus commented Jan 17, 2022

Chaosus commented Jan 21, 2022

akien-mga commented Jan 21, 2022

Improve Visual Script editor to suggest the proper visual script nodes. #56252

Improve Visual Script editor to suggest the proper visual script nodes. #56252

Conversation

Gallilus commented Dec 26, 2021 • edited Loading

proposal #3528

Gallilus commented Jan 1, 2022

fire left a comment

Choose a reason for hiding this comment

fire left a comment

Choose a reason for hiding this comment

Gallilus commented Jan 1, 2022

fire left a comment

Choose a reason for hiding this comment

akien-mga commented Jan 4, 2022

fire commented Jan 4, 2022 • edited Loading

Gallilus commented Jan 4, 2022

fire commented Jan 4, 2022 • edited Loading

Gallilus commented Jan 5, 2022

fire Jan 7, 2022

Choose a reason for hiding this comment

fire Jan 9, 2022

Choose a reason for hiding this comment

fire left a comment • edited Loading

Choose a reason for hiding this comment

fire commented Jan 9, 2022

Chaosus Jan 10, 2022

Choose a reason for hiding this comment

Gallilus Jan 11, 2022

Choose a reason for hiding this comment

Chaosus commented Jan 10, 2022

Chaosus commented Jan 10, 2022 • edited Loading

Chaosus commented Jan 10, 2022 • edited Loading

akien-mga commented Jan 10, 2022

Gallilus commented Jan 11, 2022

Gallilus commented Jan 17, 2022

Chaosus commented Jan 21, 2022

akien-mga commented Jan 21, 2022

Gallilus commented Dec 26, 2021 •

edited

Loading

fire commented Jan 4, 2022 •

edited

Loading

fire commented Jan 4, 2022 •

edited

Loading

fire left a comment •

edited

Loading

Chaosus commented Jan 10, 2022 •

edited

Loading

Chaosus commented Jan 10, 2022 •

edited

Loading