Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep order for C# exported members #54130

Merged
merged 1 commit into from
Oct 24, 2021

Conversation

raulsntos
Copy link
Member

Fixes #47465

C# script Godot inspector
image image

NOTE: Properties always appear before fields, this is because _update_exports and _update_member_info_no_exports retrieve the fields and properties separately.

Derived members appear at the top and declared members at the bottom, as far as I'm concerned that's how it works for GDScript.

@raulsntos raulsntos requested a review from a team as a code owner October 22, 2021 17:45
@akien-mga akien-mga added this to the 4.0 milestone Oct 22, 2021
Copy link
Contributor

@neikeq neikeq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Is this change desired in Godot 3.x? If so and if this PR cannot be cherry-picked automatically, it would be great to have a PR for the 3.x branch.

@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the csharp-exports branch October 24, 2021 19:19
@Byteron
Copy link
Contributor

Byteron commented Oct 25, 2021

oh my, thank you for this PR. It was driving me nuts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C# tool script displaying exported variables in wrong order in the inspector.
4 participants