Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RID's getornull() to get_or_null() #53227

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 29, 2021

As discussed here: #16863 (comment)

This is a large PR that will require many others to be rebased, but this PR is easy to redo from scratch.

Copy link
Member

@groud groud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to me.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me too, and @reduz approves too.

Needs a rebase, feel free to merge then once CI passes.

@mhilbrunner mhilbrunner merged commit ac7505e into godotengine:master Sep 30, 2021
@mhilbrunner
Copy link
Member

Thanks for breaking all the PRs 😉

Nah, thanks for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants