Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics2D: Rename default_density to default_linear_damp #5032

Merged
merged 1 commit into from
Jun 4, 2016

Conversation

akien-mga
Copy link
Member

Also adds a proper deprecating warning and tries to do some porting automatically.
Supersedes #4109.

@reduz @neikeq What do you think of the way I added the deprecation warning? Should I make this a method of Globals, e.g. set_and_deprecate("physics_2d/default_linear_damp","physics_2d/default_density")? Related to #4397.

Also adds a proper deprecating warning and tries to do some porting automatically.
Supersedes godotengine#4109.
@akien-mga
Copy link
Member Author

I've tested it on a project with default settings (no persisting physics_2d/default_density) and with a custom physics_2d/default_density, it works as expected.

The only issue is for projects which would be defining physics_2d/default_density directly via GDScript, but since we'll document this change in the release notes, it should be OK.

@neikeq
Copy link
Contributor

neikeq commented Jun 4, 2016

Your method seems fine in this case, but what about deprecating methods that have no such property in project settings?

@akien-mga
Copy link
Member Author

Your method seems fine in this case, but what about deprecating methods that have no such property in project settings?

For this we still need to go forward with what was discussed on #4397 and implement a proper method. In #4571 I duplicated all deprecated methods to add a warning when they're called, but it's tedious and a global method or macro would be better for that.

@akien-mga akien-mga merged commit 280e361 into godotengine:master Jun 4, 2016
@akien-mga akien-mga deleted the pr-defaut-linear-damp branch June 4, 2016 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants