Visually line up the selected tab with the underlying panel with borders #48561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
|
I'm quite sure this PR isn't relevant anymore. |
Without this PR, I can still reproduce the original issue as of 4.0.alpha 1839cae:
|
|
Oh yeah, I didn't set the border thick enough before, now I can see it. I wonder if the custom border size feature is worthy. |
akien-mga
approved these changes
Aug 3, 2022
Calinou
force-pushed
the
editor-theme-selected-tab-border-lineup
branch
from
8a07885 to
dc0ac50
Compare
|
Rebased and tested again, it works as expected:
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not perfect due to the lack of per-border colors in StyleBoxFlat, but it looks good enough at a glance.
This closes #48552.
Note: Not cherry-pickable to the
3.xbranch as this only applies to the new editor theme.Preview
Border Size is set to 2 to make the remaining visual discrepancy more noticeable. With Border Size set to 1, the visual discrepancy is hardly visible.