Core: Drop custom copymem/zeromem defines
#48239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been using standard C library functions `memcpy`/`memset` for these since 2016 with 67f65f6. There was still the possibility for third-party platform ports to override the definitions with a custom header, but this doesn't seem useful anymore.
akien-mga
added
enhancement
topic:core
cherrypick:3.x
|
Cherry-picked for 3.4. (Actually redone manually.) |
akien-mga
removed
the
cherrypick:3.x
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Apr 29, 2021
We've been using standard C library functions `memcpy`/`memset` for these since 2016 with 67f65f6. There was still the possibility for third-party platform ports to override the definitions with a custom header, but this doesn't seem useful anymore. Backport of godotengine#48239.
|
Note to module developers: this breaks compat for custom modules in 3.x who use those defines as in Godot. But it should be straightforward to port existing code. |
rosshadden
added a commit
to rosshadden/ECMAScript
that referenced
this pull request
Jun 10, 2021
Makes project work with godotengine/godot#48239 Signed-off-by: Ross Hadden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using standard C library functions
memcpy/memsetfor these since2016 with 67f65f6.
There was still the possibility for third-party platform ports to override the
definitions with a custom header, but this doesn't seem useful anymore.