Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX: Clarify min version requirement (10.12) in Info.plist #48227

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

akien-mga
Copy link
Member

The min requirement was upped by #45618 to have proper support for C++14.

Related to #48222.

Not needed in master, the min version was already increased in the Info.plists there.

The min requirement was upped by godotengine#45618 to have proper support for C++14.

Related to godotengine#48222.
@akien-mga akien-mga merged commit 1ba636e into godotengine:3.x Apr 27, 2021
@akien-mga akien-mga deleted the 3.x-macos-min-req-10.12 branch April 27, 2021 08:18
@bruvzg
Copy link
Member

bruvzg commented Apr 27, 2021

Screenshot 2021-04-27 at 11 11 23

For the reference, with the correct version in .plist macOS Finder will cross out the app icon and display an error message, but Steam is running executable directly, and it will probably crash anyway. Editing .plist on the user machine will also crash unless it's re-signed or signature removed.

@akien-mga
Copy link
Member Author

Cherry-picked for 3.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants