Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Area[X]D: Put physics override parameters in their own group and document that areas can be used to influence audio #47991

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Area[X]D: Put physics override parameters in their own group and document that areas can be used to influence audio #47991

merged 1 commit into from
Apr 20, 2021

Conversation

AaronRecord
Copy link
Contributor

@AaronRecord AaronRecord commented Apr 18, 2021 •
edited
Loading

A compromise that resolves godotengine/godot-proposals#2234, at least for now

Before:

After:

@AaronRecord AaronRecord requested review from a team as code owners April 18, 2021 00:58
@Calinou Calinou added this to the 4.0 milestone Apr 18, 2021
@Calinou Calinou added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 18, 2021
@AaronRecord AaronRecord force-pushed the regroup-area-inspector-4.0 branch from 6e5a2bc to 8d94423 Compare April 18, 2021 01:05
@akien-mga akien-mga requested a review from a team April 18, 2021 09:36
akien-mga
akien-mga reviewed Apr 18, 2021
View reviewed changes
scene/2d/area_2d.cpp Outdated Show resolved Hide resolved
@AaronRecord AaronRecord force-pushed the regroup-area-inspector-4.0 branch from 8d94423 to 80b1a29 Compare April 19, 2021 03:27
pouleyKetchoupp
pouleyKetchoupp approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@pouleyKetchoupp pouleyKetchoupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It does make things more clear.

@akien-mga akien-mga merged commit aa67786 into godotengine:master Apr 20, 2021
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal mentioned this pull request Apr 20, 2021
Merged
@AaronRecord AaronRecord deleted the regroup-area-inspector-4.0 branch April 20, 2021 13:00
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@madmiraal madmiraal madmiraal left review comments

@pouleyKetchoupp pouleyKetchoupp pouleyKetchoupp approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:physics
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Make Area2D just for detecting collisions, add a new node for physics and audio overrides
5 participants
@AaronRecord @akien-mga @pouleyKetchoupp @madmiraal @Calinou