[3.x] Fix for SkeletonIK not working correctly with 0 interpolation and incorrectly rotating with animation #47738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nterpolation and incorrectly rotating with animation. Now the root bone rotates differently to ensure it always rotates correctly and works with BoneAttachment nodes.
akien-mga
approved these changes
Apr 9, 2021
|
Thanks! |
This was referenced Apr 9, 2021
|
Guys, in what way exactly did #47738 change the root bone rotation? I am a noob at c++ and unable to infer this from the code. |
|
This part of the code was the change to root bone rotation: https://github.com/godotengine/godot/pull/47738/files#diff-e9b00e7251bf0b58f8ef7690a4d3dc3aeb2684fbc603d2ccfef9d9b26043e0fcR313-R336 It rotates the root bone to look at it's next child bone using |
TwistedTwigleg
deleted the
skeletonik_changes_and_bug_fixes_regressionfix2_godot3x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Godot 3.x port of #47441. The code is the same and I tested with the sample project yanorax made and I it seems to be fully working.
Closes #47381.