FileDialog: add Back/Forward buttons, add message for inaccessible folders. #47163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
force-pushed
the
macos_sandbox_file_dialog
branch
from
d5128db to
b202a0d
Compare
Calinou
approved these changes
Mar 25, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #47056, but independent of it.
Make file dialog more usable in macOS sandboxed apps.
Back/Forwardbuttons (backport fromEditorFileDialog), without these, the only way to navigate out of inaccessible folders is entering full path manually.DirAccess,is_readable/is_writable(Unix implementation only) for inaccessible folder detection.