Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PHashTranslation to OptimizedTranslation #45234

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

madmiraal
Copy link
Contributor

Part of #16863.

Note: The suggestion was to rename it CompressedTranslation. However, although it does compress the translation, as the documentation indicates, it's an "Optimized Translation" that uses compression. This is supported by the implementation, which uses a struct to hold the compressed form. This PR includes renaming this struct to make this clear.

@madmiraal madmiraal force-pushed the rename-phashtranslation branch from 9dc87b2 to 07f1cd5 Compare March 20, 2021 10:02
@madmiraal madmiraal requested review from a team as code owners March 20, 2021 10:02
@madmiraal
Copy link
Contributor Author

Rebased following merge of #46929.

@akien-mga akien-mga merged commit 6a84ade into godotengine:master Mar 22, 2021
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the rename-phashtranslation branch March 23, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants