C++: Apply some modernize-* checks from clang-tidy (nullptr, bool literals, void args)
#38736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using clang-tidy's `modernize-use-nullptr`. https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-nullptr.html
Using clang-tidy's `modernize-use-bool-literals`. https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-bool-literals.html
akien-mga
requested review from
AndreaCatania,
bojidar-bg,
hpvb,
neikeq,
vnen and
a team
as code owners
akien-mga
removed request for
a team,
hpvb,
bojidar-bg,
vnen,
neikeq and
AndreaCatania
Using clang-tidy's `modernize-redundant-void-arg`. https://clang.llvm.org/extra/clang-tidy/checks/modernize-redundant-void-arg.html
akien-mga
force-pushed
the
modernize-all-the-things
branch
from
f14c63e to
a1aaed5
Compare
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Apr 29, 2021
Follow-up to godotengine#38736 (these uses were likely added after this PR was merged).
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #38697.
See available checks at https://clang.llvm.org/extra/clang-tidy/checks/list.html
I also tried:
is_inf, and Clang on my distro can't even findcstdintby default.TTR(), soeditor/translations/extract.pywould have to be fixed (and the raw string would have to be re-escaped in Python before outputting the POT file for gettext).There's a few more that we may want to evaluate: