Fix for running the export templates with newer emscripten versions. #32448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is pretty much that
argv[0]
gets set to./this.program
, with the newer emscripten versions, and parameters are only added after this into theargv
array.(@fidli was talking about this in #32117.)
This is a really simple, no-refactor fix. I'm not familiar enough with emscripten yet to be able to make a more roboust solution, but at the very least it shows where the actual problem is.
By the way I found emscripten-core/emscripten#2431.
This is exactly the same thing, maybe they reintroduced this?
I've tested this with both the
1.38.27
, andmaster
emsdk.fixes #32117
fixes #32422