Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved CCD calculation algorithm #28595

Merged
merged 1 commit into from
May 16, 2019
Merged

Improved CCD calculation algorithm #28595

merged 1 commit into from
May 16, 2019

Conversation

AndreaCatania
Copy link
Contributor

Improved CCD calculation algorithm

Related to #16113

@AndreaCatania AndreaCatania mentioned this pull request May 2, 2019
Open
@akien-mga akien-mga added this to the 3.2 milestone May 2, 2019
@akien-mga
Copy link
Member

Note that you created this patch on the main godotengine repo instead of your fork: https://github.com/godotengine/godot/tree/AndreaCatania-patch-1

Please try to avoid this in the future, so that we keep the upstream repo with only the active branches.

@AndreaCatania
Copy link
Contributor Author

Sorry I'll do it next time, Thanks

@mhilbrunner
Copy link
Member

Whats the state of this?

@AndreaCatania AndreaCatania force-pushed the AndreaCatania-patch-1 branch from fb1f7fb to c1c8555 Compare May 16, 2019 16:58
@AndreaCatania
Copy link
Contributor Author

Once compile, can be merged

@mhilbrunner mhilbrunner merged commit c67bb5f into master May 16, 2019
@mhilbrunner mhilbrunner deleted the AndreaCatania-patch-1 branch May 16, 2019 21:11
@mhilbrunner
Copy link
Member

Merged. Thanks!

@ZingBlue
Copy link

This might be a silly question to ask but, I am running a 2D game on Godot 3.1.1 and I am having issues with Continuous CD that are really messing with the game's game play, the only file that was changed was rigid_body_bullet.cpp, if I remember correctly Bullet is only for 3D. Will this commit somewhat fix my issues with Continuous CD?

@Calinou
Copy link
Member

Calinou commented Nov 17, 2019

@ZingBlue Bullet is only used in 3D, so no. There are other issues related to Continuous CD not working as expected (#9071 in particular).

@pouleyKetchoupp pouleyKetchoupp mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

Assignees
No one assigned
Labels
enhancement topic:physics
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@AndreaCatania @akien-mga @mhilbrunner @ZingBlue @Calinou