Added all missing VisualServer bindings #15892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zylann
force-pushed
the
add_missing_vs_bindings
branch
from
bf1d80c to
8f62a84
Compare
- Added bindings for multimesh, immediate, skeleton, light, reflection probe, gi probe, lightmap, particles, camera, environment, scenario, instance - Removed draw and sync, were duplicates of force_* equivalents - Bumped binders max arguments from 11 to 13 - Wrote some wrappers as not all methods were variant-friendly
Zylann
force-pushed
the
add_missing_vs_bindings
branch
from
8f62a84 to
e415fd0
Compare
|
Merged a bit fast and noticed this only afterwards:
That's an API breakage, so:
|
akien-mga
added a commit
that referenced
this pull request
Feb 19, 2018
Those are deprecated as VS.force_sync and VS.force_draw do the same and more explicitly, but we cannot remove them without marking them as deprecated before that. Fixes issue introduced in #15892.
83 tasks
malcolmhoward
pushed a commit
to malcolmhoward/godot
that referenced
this pull request
Jul 31, 2018
Those are deprecated as VS.force_sync and VS.force_draw do the same and more explicitly, but we cannot remove them without marking them as deprecated before that. Fixes issue introduced in godotengine#15892. (cherry picked from commit fd92e57)
malcolmhoward
pushed a commit
to malcolmhoward/godot
that referenced
this pull request
Jul 31, 2018
Those are deprecated as VS.force_sync and VS.force_draw do the same and more explicitly, but we cannot remove them without marking them as deprecated before that. Fixes issue introduced in godotengine#15892. (cherry picked from commit fd92e57)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15879