Fix #19 Can't open project (with non-ASCII path) #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `class OS_Unix` the arguments in the `execute` method are converted to UTF-8, but in the `main` program's method they're inserted into a wide-char `Vector` before translating them from UTF-8 and thus the non-ASCII characters are lost. This fix converts the `argv` elements to UTF-8 using `String::utf8` before inserting them in the `Vector`.
|
Tested in windows 8.1, I created a folder named Ŝsdfsd, then I placed a project into it. I dragged and dropped the .scn project file from this directory onto the recompiled godot.exe. This was recompiled with your patch, it crashed. On the other hand when I remove the Ŝ from the folder name it works. wmain() is the only reliable fix for this on windows. |
reduz
added a commit
that referenced
this pull request
Feb 18, 2014
Fix #19 Can't open project (with non-ASCII path)
|
thanks! |
|
@kd7tck I'm not sure if my patch affects your use-case, I don't know if godot forks itself when a scene is drag-n-drop'd inside it (and thus yes, the use-case is affected by this patch) or what happens. |
This was referenced Jul 6, 2023
DeeJayLSP
pushed a commit
to DeeJayLSP/godot
that referenced
this pull request
Nov 4, 2024
[4.4 backport] Assorted web fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
class OS_Unixthe arguments in theexecutemethod are convertedto UTF-8, but in the
mainprogram's method they're inserted into awide-char
Vectorbefore translating them from UTF-8 and thus thenon-ASCII characters are lost.
This fix converts the
argvelements to UTF-8 usingString::utf8before inserting them in the
Vector.Tested in Archlinux x86_64.
Please test this change in Windows with a non-UTF-8 encoding (e.g. ISO-8859-15), it may break Windows-only behavior because the
executemethod inclass OS_Windowsdoesn't convert the arguments to UTF-8.