Fix GraphEdit::frame_rect_changed signal parameter type
#102796
Merged
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
GraphEdit::frame_rect_changed signal parameter type
This is done with diff --git a/doc/classes/GraphEdit.xml b/doc/classes/GraphEdit.xml
index 7013798..1d7ba4c 100644
--- a/doc/classes/GraphEdit.xml
+++ b/doc/classes/GraphEdit.xml
@@ -469,7 +469,7 @@
</signal>
<signal name="frame_rect_changed">
<param index="0" name="frame" type="GraphFrame" />
- <param index="1" name="new_rect" type="Vector2" />
+ <param index="1" name="new_rect" type="Rect2" />
<description>
Emitted when the [GraphFrame] [param frame] is resized to [param new_rect].
</description>Note: Please make modifications by amending the commit, and force pushing the changes, so that it stays as a single commit (see PR workflow). |
akien-mga
force-pushed
the
fix-graph-edit-frame-rect-changed-signal-parameter-type
branch
from
ef0778c to
773c894
Compare
|
I went ahead and amended the commit myself, so this should be ready to merge. |
akien-mga
approved these changes
Feb 14, 2025
Changes the parameter type from Vector2 to Rect2, which is what is actually emitted.
akien-mga
force-pushed
the
fix-graph-edit-frame-rect-changed-signal-parameter-type
branch
from
773c894 to
bcd99bd
Compare
|
Technically breaks compat, but since it's fixing a bug the previous type was likely not usable/working at all. |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the binding's parameter type from
Vector2toRect2, which is what is actually emitted.