Fix fr+oss layout issues with KP period
#102602
Merged
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Riteo Siuga <[email protected]>
Riteo
approved these changes
Feb 8, 2025
There was a problem hiding this comment.
I got a review request but I made the Wayland half of this PR, so obviously I approve it :P
That said, the logic sounds like a great way of working around most of the core issue for keypads: not only we check if the shifted symbol is a keypad sym but we also check the plain symbol.
This is still going to cause issues with non-numpad keys that have a special "plain" symbol (delete, insert, begin, etc) that shift to regular characters but that's the core issue in question.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102599.