Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightmapper: Expose the JNLM denoiser region size in the project settings #102579

Merged

Conversation

BlueCube3310
Copy link
Contributor

Exposes the region size of the JNLM lightmapper in the ProjectSettings. This will allow the user to change the region size in scenarios when the default configuration (1024) causes crashes due to timeouts.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just re-use the existing rendering/lightmapping/bake_performance/region_size property. This will change the default, but not by a lot

@BlueCube3310 BlueCube3310 force-pushed the lightmap-denoise-region-expose branch from 7cbb28f to 7ed64eb Compare February 13, 2025 11:01
@akien-mga akien-mga modified the milestones: 4.x, 4.5 Feb 13, 2025
@akien-mga akien-mga modified the milestones: 4.5, 4.4 Feb 14, 2025
@akien-mga akien-mga merged commit aeadefc into godotengine:master Feb 14, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants