Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script class icons not inheriting parent #102572

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

Z0rb14n
Copy link
Contributor

@Z0rb14n Z0rb14n commented Feb 8, 2025

Closes #102565 by re-adding an omitted check for an empty icon path. While doing git bisect, identified this commit as the cause of the problem: a20934c (see removed check). There was a check for the return value being empty that was accidentally omitted, so this PR adds it back.

Sample I used for testing:

@icon("res://icon.svg")
extends Node2D
class_name BaseClass
extends BaseClass
class_name ChildClass

image
Previously, ChildScene icon would be a circle as per the issue.

@akien-mga akien-mga changed the title Fix Script Class Icons Not Inheriting Parent Fix script class icons not inheriting parent Feb 10, 2025
@akien-mga akien-mga merged commit db7f9a0 into godotengine:master Feb 10, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'@icon' not inheriting
3 participants