Fix script class icons not inheriting parent #102572
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102565 by re-adding an omitted check for an empty icon path. While doing
git bisect
, identified this commit as the cause of the problem: a20934c (see removed check). There was a check for the return value being empty that was accidentally omitted, so this PR adds it back.Sample I used for testing:
Previously, ChildScene icon would be a circle as per the issue.