Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add a Linux job for template_debug #102423

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

akien-mga
Copy link
Member

Seems like we've been lacking this for a while, probably assuming that target=editor + target=template_debug was enough, but it's not:

  • editor: TOOLS_ENABLED + DEBUG_ENABLED
  • template_debug: DEBUG_ENABLED
  • template_release: neither

So to test what happens when DEBUG_ENABLED is defined but not TOOLS_ENABLED, we do need a template_debug build, the combination of the other two isn't enough.

For now I'm just quickly adding a duplicate Linux template build with Mono. We might want to review the build matrix and ensure we have good coverage on multiple platforms (but still taking care of not doubling the size of the build matrix - we try to strike a balance between coverage and efficiency, but time and energy wise).

@akien-mga akien-mga added this to the 4.4 milestone Feb 4, 2025
@akien-mga akien-mga requested a review from a team as a code owner February 4, 2025 17:58
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we'll want to keep it a separate job long-term, but this works as a stopgap solution

Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bug went through our tests. Let's catch it with a test.

@akien-mga akien-mga merged commit 9bfff17 into godotengine:master Feb 5, 2025
20 checks passed
@akien-mga akien-mga deleted the ci-add-template_debug-job branch February 5, 2025 10:35
@AThousandShips
Copy link
Member

Checked and the cache limit for the debug template is appropriate so works cleanly

We might want to look into merging different workflows to reduce the matrix, been thinking about that for cases like the Android templates, and seeing what the different costs are, and seeing what takes time and not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants