-
-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix seed not randomizing for particles. Fix seed being stored when fixed seed is off #102405
Conversation
bf5c8d9
to
2f3f6f6
Compare
When you enable fixed seed, you will be greeted with the randomly generated one: godot.windows.editor.dev.x86_64_zZ98gLMSdt.mp4If it's not intended then you could reset the seed when |
@@ -597,7 +597,7 @@ void CPUParticles2D::_validate_property(PropertyInfo &p_property) const { | |||
} | |||
|
|||
if (p_property.name == "seed" && !use_fixed_seed) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated now, but it's better like this.
if (p_property.name == "seed" && !use_fixed_seed) { | |
if (!use_fixed_seed && p_property.name == "seed") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the problem for GPUParticles2D
, and seed isn't stored in the file, and already stored seeds are respected
Didn't test other nodes
This would reset a manually assigned one when toggling it off and on, so think having a random seed when enabling it from scratch is worth not erasing it each time |
This is by design! That way if you see a combination you like when testing, you can freeze the random seed. |
Thanks! |
Fixes #102182