Fix slow resize Embedded Game Window #102251
Merged
+35
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some testing the performance issue was caused by the
NOTIFICATION_PROCESS
andNOTIFICATION_RESIZED
which triggered a deferred call toEmbeddedProcess::_update_embedded_process
each frame which was really unnecessarily. This helps the Floating Window but also the Editor Window when resizing the window or docks.Using a timer to update the embedded window less frequently seems to work fine. At the same time, I was able to remove the
NOTIFICATION_PROCESS
from theEmbeddedProcess
control which always bothered me.Note: It does not affect the re-rendering of the game but rather the unresponsiveness of the window.
Note 2: There's an issue actually when resizing the game window, sometime, it stop resizing and focuses the game window. This was fixed in #102247.