Fix wrong distance calculation in NavMeshQueries3D::_query_task_build_path_corridor
#101968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Tested using 4.4beta1 and the example (#101955) and can confirm the issue with the agent.
Downloaded the Windows client artifact, unzipped and tested using the example issue, and can confirm that the agent paths as expected.
smix8
approved these changes
Jan 24, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #101955
Regression introduced (by me) here
For short, we can't take the squared version here, as the final score is a combination of multiple scores, squaring one part bias the whole result.
( the other
distance_squaredadded in the linked PR are fine, only those two needs to be reverted).