Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGL: Support native ASTC compression when available #101932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WebGL: Support native ASTC compression when available #101932

wants to merge 1 commit into from
+1 −1

Conversation

BlueCube3310
Copy link
Contributor

Adds support for checking against the WEBGL_compressed_texture_astc extension for WebGL.

@BlueCube3310 BlueCube3310 requested a review from a team as a code owner January 22, 2025 19:47
@BlueCube3310 BlueCube3310 added this to the 4.x milestone Jan 22, 2025
@BlueCube3310 BlueCube3310 mentioned this pull request Jan 22, 2025
Merged
fire
fire approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to test this, but the paper review is ok.

@clayjohn clayjohn modified the milestones: 4.x, 4.5 Jan 24, 2025
@clayjohn
Copy link
Member

Looks great! Let's merge for 4.5 so we can find out which browsers advertise support for ASTC but collapse when they are actually given an ASTC texture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@fire fire fire approved these changes

Assignees
No one assigned
Labels
enhancement platform:web topic:rendering topic:3d
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
3 participants
@BlueCube3310 @clayjohn @fire