Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Quick Open theming #101598

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MewPurPur
Copy link
Contributor

@MewPurPur MewPurPur commented Jan 15, 2025

Addresses some, but not all points in: godotengine/godot-proposals#11558

The things I've fixed are the issues with spacing and sizing.

Changed up the structure of list elements to prevent thumbnails from stretching vertically. Here's how this looked before:

image

Changed up the structure of grid elements too, to give some space above and to have better spacing. Here's how it looked before:

image

And there's now no spacing between elements, prevent you from accidentally clicking on the tiny space between.

I've also fixed the ugly hover style, which came from overriding the nonexistent "hover" style instead of "hovered".

Here's how it looks now:

image

image

Please tell me if you think the spacing is too tight now.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

image

The amount of spacing looks good to me. However, the icons aren't centered in the hovered/selected area:

image

There are 6 pixels above the icon and 7 pixels below the icon. (The icon is 36 pixels tall.)
I can notice this issue across every item, so it's not specific to some items on the list.

I suggest adding 1 pixel of padding at the top so it's even.

@MewPurPur
Copy link
Contributor Author

Sure. This is because the vboxcontainer with the text is 37px tall, because text has this tendence of taking more space than what it seems like it should.

I'll fix it.

@MewPurPur
Copy link
Contributor Author

Doned, bumping up the "anti-separation" of the two labels by 1 more pixel looks good to me even with the maximum ascents/descents in the default font.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and even now 🙂

image

It's still a tad uneven at 200% editor scale (10 pixels above the icon, 11 pixels below) but it's probably unnoticeable on an actual hiDPI display.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants