-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak Quick Open theming #101598
base: master
Are you sure you want to change the base?
Tweak Quick Open theming #101598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected.
The amount of spacing looks good to me. However, the icons aren't centered in the hovered/selected area:
There are 6 pixels above the icon and 7 pixels below the icon. (The icon is 36 pixels tall.)
I can notice this issue across every item, so it's not specific to some items on the list.
I suggest adding 1 pixel of padding at the top so it's even.
Sure. This is because the vboxcontainer with the text is 37px tall, because text has this tendence of taking more space than what it seems like it should. I'll fix it. |
90ba26b
to
3ddf6ad
Compare
Doned, bumping up the "anti-separation" of the two labels by 1 more pixel looks good to me even with the maximum ascents/descents in the default font. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addresses some, but not all points in: godotengine/godot-proposals#11558
The things I've fixed are the issues with spacing and sizing.
Changed up the structure of list elements to prevent thumbnails from stretching vertically. Here's how this looked before:
Changed up the structure of grid elements too, to give some space above and to have better spacing. Here's how it looked before:
And there's now no spacing between elements, prevent you from accidentally clicking on the tiny space between.
I've also fixed the ugly hover style, which came from overriding the nonexistent "hover" style instead of "hovered".
Here's how it looks now:
Please tell me if you think the spacing is too tight now.