Add LocalVector
move semantics (constructor and operator=).
#100560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently begun to introduce move semantics to core, for its performance benefits. Examples of functions that can benefit a lot from move semantics include SWAP (#100367), reduce_at and insert (#100477), and simple data transfer. For more information on motivation, see #100426.
For
LocalVector
, this is especially important because a copy-constructor and copy-assignment is forced to copy the entire array, and all elements in it.Examples
This time I've gathered relevant beneficiaries through a
[[deprecated]]
trick. Here are some examples:godot/modules/navigation/3d/nav_mesh_queries_3d.cpp
Lines 923 to 929 in 6395450
(the memory no longer has to be re-allocated to return the vector)
The same was happening in
ShaderPreprocessor::advance
:godot/servers/rendering/shader_preprocessor.cpp
Line 122 in 6395450
SWAP
calls also required double reallocations in e.g. OAHashMap on insert:godot/core/templates/oa_hash_map.h
Lines 133 to 135 in 6395450
e.g .from ShaderGLES3::Version::Specialization items:
godot/drivers/gles3/shader_gles3.h
Lines 95 to 100 in 6395450
There's some more examples but I think that should be enough evidence that the addition is warranted :)