-
-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight hovered GraphEdit
connection by widening the line
#100456
Highlight hovered GraphEdit
connection by widening the line
#100456
Conversation
ca908eb
to
09a5527
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I like this idea, and it fits pretty good in the VisualShader editor, I'm against removing the tint color.
If someone doesn't like highlighting via color, they can just set the tint color to a color with an alpha value of 0.
By setting the default value of connection_hover_thickness
to 0%, we wouldn't even need to break compatibility.
09a5527
to
5a183ee
Compare
5a183ee
to
53944bf
Compare
Sounds good. I have removed the removal of the tint color. |
Even if GraphEdit is experimental, I'd suggest using 0% as a default value for the widening, as we would still kind of break compatibility (in the manner of a changed default visual appearance that some users might not prefer). |
53944bf
to
04077da
Compare
This change causes the connections to be additionally highlighted by widening the line with a configurable factor.
04077da
to
0a875ab
Compare
Thanks! |
Currently, GraphEdit connections are highlighted by tinting the color. With this change, the connections are highlighted by widening the line by a configurable factor.
The current method of highlighting connections has the following two properties:
Replacing the tint color by a configurable theme option solves these issues and also additionally allows users to change the settings in a way, that ho highlight happens.
While this PR changes the theme-API and is therefore technically compatibility breaking, theThis is no longer an issue, since theme properties are no longer removed.GraphEdit
node is still marked as experimental, so this should not be a deal-breaker.CC @Geometror
Updated 2024-12-18: Set default values to 0%.