Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AnimationNodeExtension extend AnimationNode instead of AnimationRootNode #100416

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Dec 14, 2024

Context #99181 (comment)

we will need two (or three) Extensions, AnimationRootNodeExtension and AnimationNodeSyncExtension (and AnimationNodeExtention). If it is not an Extension by replacement, then only the AnimationNode needs to be replaced.

This PR makes it no longer allow the AnimationNodeExtention to be placed "directly" in the StateMachine as an Extension, but provides a workaround to place it by wrapping it in a NodeBlendTree.

Perhaps this class should be deprecated in the future and this should all be done in the AnimationNode after implementing GDScript struct.

@TokageItLab TokageItLab added this to the 4.4 milestone Dec 14, 2024
@TokageItLab TokageItLab requested review from a team as code owners December 14, 2024 21:35
@TokageItLab TokageItLab mentioned this pull request Dec 14, 2024
1 task
@AThousandShips AThousandShips changed the title Make AnimationNode extend AnimationNode instead of AnimationRootNode Make AnimationNodeExtension extend AnimationNode instead of AnimationRootNode Dec 14, 2024
@GuilhermeGSousa
Copy link
Contributor

Do you want me to add extension for Root and Sync nodes as well?

@TokageItLab
Copy link
Member Author

I don't know how much demand there is for that. As I wrote in description, RootNode can be solved by wrapping with BlendTree, and Sync may not really be that important as well since it only adds a property that does nothing by itself.

@TokageItLab TokageItLab requested a review from fire December 16, 2024 21:45
@akien-mga akien-mga merged commit 9830780 into godotengine:master Dec 17, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants