-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree
highlight selected items on hover
#100412
base: master
Are you sure you want to change the base?
Conversation
1284b0e
to
0051935
Compare
0051935
to
aff67b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected. I made sure no unnecessary redrawing occurs.
tree_hover_editor.mp4
tree_hover_project.mp4
However, when using a light editor theme, hover text becomes white when it should remain black:
tree_hover_editor_light.mp4
aff67b9
to
03caf44
Compare
Is fixed in editor_theme_manager.cpp line 960. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great on light theme now 🙂
Hovered items of a
Tree
are now highlighted, even if they are already selected.Equivalent to this pr #99361, but for the
Tree
node.Relates to godotengine/godot-proposals#7404