Simplify NavMeshQueries3D::simplify_path_segment
#100401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiroxas
force-pushed
the
Simplify_NavMeshQueries3D_simplify_path_segment
branch
from
f2ec05f to
1367aec
Compare
smix8
approved these changes
Dec 16, 2024
Repiteo
reviewed
Dec 16, 2024
kiroxas
force-pushed
the
Simplify_NavMeshQueries3D_simplify_path_segment
branch
from
1367aec to
774e914
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of intermediate sparse vector, and directly push into result.
No need to reconstruct at the end.
During my tests, this was saving around 2 000 cycles of startup time. The algorithm is the same, so no gain there.
This was discussed in this code review