Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rebuild tree when selecting a file in FileSystem list view #100376

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

larspet
Copy link
Contributor

@larspet larspet commented Dec 13, 2024

Similar to #100010

Ever since #21426 the FileSystem tree has been rebuilt everytime a file is selected while using the split view. I cannot find a reason for this.

Since only folders are shown in the tree when using the split view this has not had a huge performance impact, but could potentially be noticeable in a large project with many folders.

@KoBeWi KoBeWi modified the milestones: 4.x, 4.4 Dec 14, 2024
@Repiteo Repiteo merged commit 129aae7 into godotengine:master Dec 16, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 16, 2024

Thanks!

@larspet larspet deleted the filesystem-tree-rebuild branch December 19, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants