Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect text in the Node Configuration Warning dialog #94145

Closed
MovaUA opened this issue Jul 9, 2024 · 2 comments · Fixed by #94147
Closed

Incorrect text in the Node Configuration Warning dialog #94145

MovaUA opened this issue Jul 9, 2024 · 2 comments · Fixed by #94147
Labels
bug topic:editor topic:2d
Milestone
4.3

Comments

@MovaUA
Copy link
Contributor

MovaUA commented Jul 9, 2024

Tested versions

The dialog Node Configuration Warning! refers to the property Frames, but the actual name of the referenced property is Sprite Frames.

See the details in the screenshot below:
Screenshot 2024-07-09 at 7 00 35 PM

System information

Godot Engine v4.2.2.stable.official.15073afe3 - https://godotengine.org Vulkan API 1.2.231 - Forward+ - Using Vulkan Device #0: Apple - Apple M2 Max System Software Overview: System Version: macOS 14.5 (23F79) Kernel Version: Darwin 23.5.0

Issue description

The dialog Node Configuration Warning! refers to the property Frames, but the actual name of the referenced property is Sprite Frames.

Steps to reproduce

Follow the steps described at GODOT DOCS / Your first 2D game / Creating the player scene / Sprite animation

Minimal reproduction project (MRP)

See https://github.com/MovaUA/godot-dodge-the-creeps-2d
@Mickeon
Copy link
Contributor

Mickeon commented Jul 9, 2024

This is the case for AnimatedSprite3D as well.

@MovaUA MovaUA mentioned this issue Jul 9, 2024
Merged
@MovaUA
Copy link
Contributor Author

MovaUA commented Jul 9, 2024

This is the case for AnimatedSprite3D as well.

This is fixed as a part of #94147
Thank you.

@akien-mga akien-mga added this to the 4.3 milestone Jul 10, 2024
sorascode pushed a commit to sorascode/godot-soras-version that referenced this issue Jul 22, 2024
@MovaUA @sorascode
Fix Issue godotengine#94145 Incorrect text in the Node Configuration …
080324d 
…Warning dialog

Fix some translations

Revert "Fix some translations"

This reverts commit 61e586ef84fb962eefdc14593241c1d8b0fb7b6b.

Revert "Fix Issue godotengine#94145 Incorrect text in the Node Configuration Warning dialog"

This reverts commit d0832dc5e7f0657744780cdfc97ed40772ea717c.

msgid

warnings.push_back(RTR("A SpriteFrames resource must be created or set in the \"Sprite Frames\"

revert editor/translations/editor
Akeal pushed a commit to Akeal/godot that referenced this issue Jul 24, 2024
@MovaUA @Akeal
Fix Issue godotengine#94145 Incorrect text in the Node Configuration …
79535c1 
…Warning dialog

Fix some translations

Revert "Fix some translations"

This reverts commit 61e586ef84fb962eefdc14593241c1d8b0fb7b6b.

Revert "Fix Issue godotengine#94145 Incorrect text in the Node Configuration Warning dialog"

This reverts commit d0832dc5e7f0657744780cdfc97ed40772ea717c.

msgid

warnings.push_back(RTR("A SpriteFrames resource must be created or set in the \"Sprite Frames\"

revert editor/translations/editor
Luis-Wong pushed a commit to Luis-Wong/godot that referenced this issue Jul 26, 2024
@MovaUA @Luis-Wong
Fix Issue godotengine#94145 Incorrect text in the Node Configuration …
d285079 
…Warning dialog

Fix some translations

Revert "Fix some translations"

This reverts commit 61e586ef84fb962eefdc14593241c1d8b0fb7b6b.

Revert "Fix Issue godotengine#94145 Incorrect text in the Node Configuration Warning dialog"

This reverts commit d0832dc5e7f0657744780cdfc97ed40772ea717c.

msgid

warnings.push_back(RTR("A SpriteFrames resource must be created or set in the \"Sprite Frames\"

revert editor/translations/editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor topic:2d
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Fixes/node configuration warning dialog text
4 participants
@akien-mga @MovaUA @Mickeon @AThousandShips