Can't open Animation tab with if a shader resource is expanded in the inspector, reverts to Shader Editor again

[lostminds]

Godot version

4.0beta10

System information

macOS 13.0.1

Issue description

If you expand a shader resource in the inspector panel this automatically opens the Shader Editor tab in the bottom panel. However, there seems to be a bug with the Animation tab that somehow triggers this again when the animation tab is opened (maybe it refreshes the inspector?), resulting in the Shader Editor immediately being opened again. So, if you have a shader resource expended in the inspector you can't open the Animation tab to edit animations. If you just collapse the shader resource again it works as expected.

Screen.Recording.2022-12-29.at.15.42.17.mov

I tried this in 4.0 beta 8 as well, and interestingly it had the same problem but also another bug/hack that caused the expanded shader resource to be collapsed when it switched back to the Shader Editor. So if you clicked the Animation tab a second time you could now switch to it.

Steps to reproduce

Create new scene (2d or 3d)
Add an AnimationPlayer to the scene so there's something in the Animation tab
Open the animation tab with the Animation player selected
Create something (2d or 3d) that has a material
Assign a new shader material
Create a new shader for the material
Expand the material and shader resources in the inspector
Notice that this opens the shader editor in the bottom
Now try to open the animation tab, notice it will switch back to the shader editor tab immediately

Minimal reproduction project

animation_tab_test.zip

[Calinou]

I can confirm this on 4.0.beta10 while working on godotengine/godot-demo-projects#809.

[TokageItLab]

Duplicate of #70588

[lostminds]

This bug, and probably #70588 then too has reappeared again in 4.0b15 : If you have a Shader resource expanded in the inspector you can't switch to the Animation tab as it will keep the Shader Editor tab open.

[akien-mga]

CC @KoBeWi

[KoBeWi]

Caused by #70909
It's the same issue as the one fixed by the reverted PR, i.e. pressing Animation will reload inspector and reopen all properties, triggering unwanted editors.

[TokageItLab]

Now that #71770 has been merged, it may be worth re-applying the two commits that were Reverted in #70909, if the issue in #70914 does not occur again.