Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error on Fedora 41 with builtin_mbedtls=no #102957

Closed
Calinou opened this issue Feb 17, 2025 · 0 comments · Fixed by #102964
Closed

Build error on Fedora 41 with builtin_mbedtls=no #102957

Calinou opened this issue Feb 17, 2025 · 0 comments · Fixed by #102964

Comments

@Calinou
Copy link
Member

Calinou commented Feb 17, 2025

Tested versions

  • Reproducible in: 4.4.beta 93d2706

System information

Godot v4.4.beta (93d2706) - Fedora Linux 41 (KDE Plasma) on X11 - X11 display driver, Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (nvidia; 565.77) - 13th Gen Intel(R) Core(TM) i9-13900K (32 threads)

Issue description

I get a build error on Fedora 41 with builtin_mbedtls=no:

modules/mbedtls/tls_context_mbedtls.cpp: In member function 'Error TLSContextMbedTLS::init_server(int, Ref<TLSOptions>, Ref<CookieContextMbedTLS>)':
modules/mbedtls/tls_context_mbedtls.cpp:151:57: error: 'MBEDTLS_SSL_VERSION_TLS1_2' was not declared in this scope; did you mean 'MBEDTLS_SSL_PROTO_TLS1_2'?
  151 |                 mbedtls_ssl_conf_max_tls_version(&conf, MBEDTLS_SSL_VERSION_TLS1_2);
      |                                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                         MBEDTLS_SSL_PROTO_TLS1_2
modules/mbedtls/tls_context_mbedtls.cpp:151:17: error: 'mbedtls_ssl_conf_max_tls_version' was not declared in this scope; did you mean 'mbedtls_ssl_conf_max_version'?
  151 |                 mbedtls_ssl_conf_max_tls_version(&conf, MBEDTLS_SSL_VERSION_TLS1_2);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                 mbedtls_ssl_conf_max_version
modules/mbedtls/tls_context_mbedtls.cpp: In member function 'Error TLSContextMbedTLS::init_client(int, const String&, Ref<TLSOptions>)':
modules/mbedtls/tls_context_mbedtls.cpp:198:57: error: 'MBEDTLS_SSL_VERSION_TLS1_2' was not declared in this scope; did you mean 'MBEDTLS_SSL_PROTO_TLS1_2'?
  198 |                 mbedtls_ssl_conf_max_tls_version(&conf, MBEDTLS_SSL_VERSION_TLS1_2);
      |                                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                         MBEDTLS_SSL_PROTO_TLS1_2
modules/mbedtls/tls_context_mbedtls.cpp:198:17: error: 'mbedtls_ssl_conf_max_tls_version' was not declared in this scope; did you mean 'mbedtls_ssl_conf_max_version'?
  198 |                 mbedtls_ssl_conf_max_tls_version(&conf, MBEDTLS_SSL_VERSION_TLS1_2);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                 mbedtls_ssl_conf_max_version

In comparison, it works with builtin_mbedtls=yes (the default). This is likely a regression from #102774. cc @Faless

Steps to reproduce

  • Run scons builtin_mbedtls=no on Fedora 41 with the system mbedTLS package installed.

Minimal reproduction project (MRP)

N/A

@akien-mga akien-mga self-assigned this Feb 17, 2025
@akien-mga akien-mga added this to the 4.4 milestone Feb 17, 2025
rt9391 pushed a commit to rt9391/rt9391godot2 that referenced this issue Feb 21, 2025
Relevant for Linux distribution packages which may link against system Mbed TLS.

Fixes godotengine#102957.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants