Improve docs on TIME #3494
Improve docs on TIME #3494
Conversation
| | in float **TIME** | Global time, in seconds. | | ||
| | | It's subject to the rollover setting (which is 3,600 -1 hour- by default). | | ||
| +-----------------------+-----------------------------------------------------------------------------+ | ||
| | in vec4 **MODULATE** | Final modulate color. | |
There was a problem hiding this comment.
The way you have defined MODULATE it is not a global built-in, it is a built in that is available in all three shader functions. Global built-ins are a special type that is accessible everywhere, including custom functions. They are only available in master, and are specified with "global" keyword. see godotengine/godot#37166
There was a problem hiding this comment.
Understood.
But now I'm confused about master in this repo being for 3.2. Is that no longer true? If that's the case, I guess I can leave the changes to TIME here and move on MODULATE to a separate PR for 3.2.
There was a problem hiding this comment.
I think master in this repo is for 4.0 because there is a separate 3.2 branch. So yea, maybe leave this PR with the time changes and then make another PR with the modulate changes for 3.2.
There was a problem hiding this comment.
Yeah, master here is for Godot 4.0 now. :)
There was a problem hiding this comment.
PR updated to include only the TIME stuff.
There was a problem hiding this comment.
BTW, the PR template says that master is fo 3.0. Maybe it needs an update.
RandomShaper
changed the title
|
Thanks! |
And improve TIME.
(OMG, after two messed up PRs, I've finally been able to do it.)