Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D IK demo (fixed) #226

Merged
merged 1 commit into from
Mar 31, 2018
Merged

Conversation

TwistedTwigleg
Copy link
Contributor

Alright, hopefully everything is working now. This PR is the same as PR #225. with the fixes suggested there applied. I had to make a new PR because Github had issues with the IK folder being renamed to ik.

Sorry if making another PR causes issues / extra work. I could not (after several attempts) figure out a way to remove the IK folder (despite git saying it was not there... Not sure what was going on).

See #225 for details. Closes #211 (and maybe #3)

Three scenes are included, one of which shows a example use case.
@TwistedTwigleg TwistedTwigleg mentioned this pull request Mar 17, 2018
Copy link

@pwab pwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got some errors on first startup telling me that some images couldn't be preloaded. But everything worked fine and I'm not able to reproduce so don't mind.

Well done 👍

@TwistedTwigleg
Copy link
Contributor Author

Thanks pwab!

@NathanLovato
Copy link
Contributor

Tried the project, it runs well and that's already a sizeable demo! Thanks for your work. I'm merging as it runs smoothly and the code is well-commented, but I think the code style could use some extra review and work after that if anyone is up for the task.

I'm talking about things like using abbreviations for variable names while Godot 3's api moved to more readable properties. Leaving some code that's not in use as well. As this is a public demo for learning purposes and the code is quite complex, the more self-documented and organized it can be the better.

@NathanLovato NathanLovato merged commit fc08eda into godotengine:master Mar 31, 2018
@mrcdk
Copy link
Contributor

mrcdk commented Apr 16, 2018

Has the IK addon been released in the asset library? I can't find it. I think it should be released as an standalone addon there too so people that test the demo can use it in their own projects (without the need to copy and paste it into their projects)

@TwistedTwigleg
Copy link
Contributor Author

Has the IK addon been released in the asset library?

No, I haven’t uploaded the IK addon to the asset library.

I can see about getting it up there later if you guys want, I’ll just need to figure out what’s needed to add it to the asset library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Demo: IK Demo
5 participants