Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix squash_the_creeps hitboxes #1019

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Fix squash_the_creeps hitboxes #1019

merged 2 commits into from
Mar 6, 2024

Conversation

Nazarwadim
Copy link
Contributor

I added CollisionShapes for the player and the enemy to fix the bug of the enemy passing through the player.
image
image

Calinou
Calinou requested changes Mar 5, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, the collision shapes don't rotate when the player rotates (which happens when you move):

image

It works on enemies though.

@Nazarwadim Nazarwadim force-pushed the fix_squash_the_creeps_hitboxes branch from db85277 to abdb8b9 Compare March 6, 2024 11:47
Calinou
Calinou approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

Thanks!

@Calinou Calinou merged commit b8a8670 into godotengine:master Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nazarwadim @Calinou