-
-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android/iOS build, Scons boilerplate for building projects. #636
Conversation
Looks good to me overall, it's a good cleanup. We discussed the new I think we can think some more about how we want to do things to support both tests and the usual But AFAICT this PR doesn't break existing projects, it just provides a new option to use |
01bb55d
to
fbf6883
Compare
Updated based on feedback so projects now can include the library |
Works by executing project `SConstruct`s file in a cloned env (a bit like Godot does for modules) so you don't have to worry about platform and toolchain setup. Convert the project test file to work as submodule, add it to CI Run with: ``` scons build_projects=test,/path/to/other/project ```
fbf6883
to
90b7d05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I'm not 100% sure if the way the compilation of the test project works is the way around I would like I don't think that issue is important enough or will get in the way of people using the library the way they are now. Being able to compile all platforms and having this code cleaned up far outweighs that concern and we can always improve on it.
So I'm very happy to see these changes finally merged.
In this PR:
Convert the project test file to work use the env from the libary.
Build the test with:
Or, if you prefer building the library separately:
Follow up on what I proposed in #635